[PATCH] D51956: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

[Zachary Turner via llvm-commits]

If you’re uploading to build server, i don’t think it would be an error, it
would either overwrite or not. If it does overwrite, debugging the exe
matching the pdb that was there before wouldn’t work, and if it did not
overwrite debugging the new exe would fail.

That said, my point was mainly that the probability of this being an issue
in practice is negligible
On Fri, Sep 14, 2018 at 12:06 PM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> In https://reviews.llvm.org/D51956#1235313, @llvm-commits wrote:
>
> > The symptoms of a collision are just going to be you can’t debug the
> >  program, so not very severe imo, especially since it would almost
> certainly
> >  be resolved on the next incremental build
>
>
> Can you explain how it would lead to you not being able to debug the
> program?
>
> Do you mean for local builds? If so, if two back-to-back builds end up
> with the same pdb guid in the exe and pdb by chance even though the pdb
> changes, the debugger should still load the new pdb off disk fine (?)
>
> Do you mean if a build server produces PDBs with the same guid for
> different builds? If so, that would probably produce an error during pdb
> upload and make the build fail, not debugging (?)
>
>
> https://reviews.llvm.org/D51956
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180914/fdf18393/attachment.html>