[PATCH] D51956: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In https://reviews.llvm.org/D51956#1235313, @llvm-commits wrote:

> The symptoms of a collision are just going to be you can’t debug the
>  program, so not very severe imo, especially since it would almost certainly
>  be resolved on the next incremental build


Can you explain how it would lead to you not being able to debug the program?

Do you mean for local builds? If so, if two back-to-back builds end up with the same pdb guid in the exe and pdb by chance even though the pdb changes, the debugger should still load the new pdb off disk fine (?)

Do you mean if a build server produces PDBs with the same guid for different builds? If so, that would probably produce an error during pdb upload and make the build fail, not debugging (?)


https://reviews.llvm.org/D51956