[PATCH] D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/CodeGen/X86/pr38763.ll:1
+; RUN: llc -O2 %s -o %t -filetype=obj
+; RUN: llvm-dwarfdump -debug-info %t | FileCheck %s
----------------
Sine you are testing SimplifyCFG, it would be much better to just run that one pass via opt and check the result immediately after it.


================
Comment at: test/CodeGen/X86/pr38763.ll:7
+; When in the debugger, on the line "if (read == 4)", the value of "result"
+; is reported as '2', where it should be zero.
+
----------------
This is not a helpful description of the test. It would be easier to understand what the test is testing for if it said something like: "When SimplifyCFG folds two PHI instructions into a conditional instruction, the debug info becomes ambiguous..." (not sure if that is what actually happens but you get the idea.)


Repository:
  rL LLVM

https://reviews.llvm.org/D51976