[PATCH] D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger

[Tom Weaver via Phabricator via llvm-commits]

TWeaver added a comment.

couple of nitpicks.



================
Comment at: lib/Transforms/Utils/Local.cpp:2528
+  findDbgUsers(DbgUsers, &I);
+  for (DbgVariableIntrinsic *DII : DbgUsers)
+    DII->eraseFromParent();
----------------
I'd use for (auto &DII : DbgUsers) here. The type is obvious from the declaration of DbgUsers. This should make this line a little easier on the eyes.


================
Comment at: lib/Transforms/Utils/Local.cpp:2528
+  findDbgUsers(DbgUsers, &I);
+  for (DbgVariableIntrinsic *DII : DbgUsers)
+    DII->eraseFromParent();
----------------
TWeaver wrote:
> I'd use for (auto &DII : DbgUsers) here. The type is obvious from the declaration of DbgUsers. This should make this line a little easier on the eyes.
is DII the correct name for the iterator here? should this be DVI inline with the name of the type used in the declaration of DbgUsers?

That is : DVI for DbgVariableIntrinsic.


Repository:
  rL LLVM

https://reviews.llvm.org/D51976