[PATCH] D51913: [libFuzzer] [Windows] Include windows.h and psapi.h with lowercase

Tue Sep 11 01:02:59 PDT 2018

mstorsjo added a comment.

In https://reviews.llvm.org/D51913#1230094, @smeenai wrote:

> The existing capitalization (as in before your change) is the correct one for these headers in the Windows SDK,

FWIW, the second file is inconsistent in this regard as it includes `windows.h` but `Psapi.h`.

> and it's also possible to cross-compile against the Windows SDK on a case-sensitive filesystem. However, doing that cross-compilation requires using a VFS overlay or case-correcting symlinks or ciopfs or whatever anyway, because the casing in the rest of the Windows SDK is hopelessly broken, so I'm okay with this change. I'll let @rnk confirm that it's okay to change the capitalization to the non-Windows SDK form though, and I'm also CCing @zturner since he also did cross-compilation work against the Windows SDK on Linux.

FWIW, I'm also occasionally doing cross-compilation with the Windows SDK (although mingw is what I'm spending most effort on), and my approach so far has been to run a script over the headers (and import libraries) to lowercase them, because they are, as you noted, hopelessly broken in their current form.

Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51913