[PATCH] D51913: [libFuzzer] [Windows] Include windows.h and psapi.h with lowercase

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 00:55:48 PDT 2018


smeenai added a subscriber: zturner.
smeenai added a comment.

The existing capitalization (as in before your change) is the correct one for these headers in the Windows SDK, and it's also possible to cross-compile against the Windows SDK on a case-sensitive filesystem. However, doing that cross-compilation requires using a VFS overlay or case-correcting symlinks or ciopfs or whatever anyway, because the casing in the rest of the Windows SDK is hopelessly broken, so I'm okay with this change. I'll let @rnk confirm that it's okay to change the capitalization to the non-Windows SDK form though, and I'm also CCing @zturner since he also did cross-compilation work against the Windows SDK on Linux.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51913





More information about the llvm-commits mailing list