[PATCH] D51887: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 16:39:41 PDT 2018


ruiu added a comment.

Oh, I read "this" as my suggestion. :)

But computing a hash of a continuous region in memory is much easier than defining a new Stream, no? If you take a look at the code in ELF that computes a build-id, I think you'll notice that's pretty short. It also eliminates the need to modify xxhash.h.


https://reviews.llvm.org/D51887





More information about the llvm-commits mailing list