[PATCH] D51887: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 16:33:28 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D51887#1229702, @ruiu wrote:

> Sequential file access might be fast enough, so I don't know which is better performance-wise. In such situation, I'd probably try to implement an easier one (hashing a mmap'ed buffer) to see if it is satisfactory, or try to implement both to compare if not, to keep it as simple as possible.


I guess we have different ideas about what is simple. :)


https://reviews.llvm.org/D51887





More information about the llvm-commits mailing list