[PATCH] D51671: [ELF] Set Out::TlsPhdr earlier for encoding packed reloc tables

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 02:25:21 PDT 2018


rprichard added inline comments.


================
Comment at: ELF/Writer.cpp:1654
+
+    for (PhdrEntry *P : Phdrs)
+      if (P->p_type == PT_TLS && P->FirstSec) {
----------------
srhines wrote:
> const?
We'd also have to make Out::TlsPhdr point to a const PhdrEntry. Do we want to do that? The rest of the section fields in InX and Out aren't const.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51671





More information about the llvm-commits mailing list