[PATCH] D51671: [ELF] Set Out::TlsPhdr earlier for encoding packed reloc tables

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 01:04:28 PDT 2018


srhines added a comment.

Thanks for the detailed explanations. I only had one minor nitpick.



================
Comment at: ELF/Writer.cpp:1654
+
+    for (PhdrEntry *P : Phdrs)
+      if (P->p_type == PT_TLS && P->FirstSec) {
----------------
const?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51671





More information about the llvm-commits mailing list