[PATCH] D51048: cmake: Specify reference outputs in llvm_test_data()

[Pankaj via Phabricator via llvm-commits]

proton accepted this revision.
proton added a comment.
This revision is now accepted and ready to land.

LGTM

> I don't understand this. `llvm_test_verify_hash_program_output()` only inserts a hashing step to the verification script, you still need the final `fpcmp` invocation (and the WORKDIR setting is separate for every step).

In the definition of `llvm_test_verify_hash_program_output()`, `llvm_test_verify(WORKDIR ${CMAKE_CURRENT_BINARY_DIR}  ${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${_file})` is called which sets the work directory to current binary directory. So we need not call `llvm_test_verify` with `WORKDIR ${CMAKE_CURRENT_BINARY_DIR}` argument after `llvm_test_verify_hash_program_output`, simply `llvm_test_verify(${FPCMP} bilinear.reference_output bilinearOutput.txt)` will work. Passing WORKDIR argument does not cause any harm though.

> My motivation there was to not rewrite these `CMakeFiles` much more than necessary. You can probably shorten them by introducing a higher level macro that combines the hashing + fpcmp for multiple files. But that should be done in a separate commit.

Okay.


Repository:
  rT test-suite

https://reviews.llvm.org/D51048