[PATCH] D51048: cmake: Specify reference outputs in llvm_test_data()

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 15:27:40 PDT 2018


MatzeB added a comment.

And for some context about the seemingly excessive use of `WORKDIR ${CMAKE_CURRENT_BINARY_DIR}` here: One of my original plans was to make the test-suite build directory relocatable, i.e. after building you could move it to any other directory and still correctly run the benchmarks. That would mean have to stop using absolute paths and need to express everything relative to the benchmark binary. I hoped that an intermediate step towards this is changing as much as possible to `WORKDIR ${CMAKE_CURRENT_BINARY_DIR}` + relative paths. A next step would then be to change the default workdir to the binary dir.

This needs some more changes especially in the SPEC benchmarks though. Also it seems like I don't really need relocatability for my use cases though so I currently don't plan to push to finish this. Either way making some of the changes here and in my other commits didn't hurt...


Repository:
  rT test-suite

https://reviews.llvm.org/D51048





More information about the llvm-commits mailing list