[PATCH] D50591: [PGO] Control Height Reduction

[David Li via Phabricator via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm.



================
Comment at: lib/Passes/PassBuilder.cpp:494
 
+  if (EnableCHR && Level == O3 && PGOOpt && !PGOOpt->ProfileUseFile.empty())
+    FPM.addPass(ControlHeightReductionPass());
----------------
davidxl wrote:
> How about SamplePGO ?
In thinLTO mode, you may want to only do this in the backend compilation, otherwise, there is a risk that that fallback path gets CHRed again which is not desirable.


Repository:
  rL LLVM

https://reviews.llvm.org/D50591