[PATCH] D50591: [PGO] Control Height Reduction

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: lib/Transforms/Instrumentation/ControlHeightReduction.cpp:1808
+  assert(Bias >= getCHRBiasThreshold() && "Must be highly biased");
+  CHRBranchBias *= Bias;
+  BasicBlock *IfThen = BI->getSuccessor(1);
----------------
davidxl wrote:
> This might be too conservative that the merged branch becomes less biased as it can be.  It is very likely that the contributing branches are correlated.  How about taking the 'min' BranchProb as the resulting BP?
Done.


Repository:
  rL LLVM

https://reviews.llvm.org/D50591