[PATCH] D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 15:40:39 PDT 2018


volkan added a comment.

I had a similar discussion with Quentin a while ago and it seemed there are two solutions:

- Add a pass to canonicalize MIR
- Extend MIRBuilder to canonicalize instructions

I think it makes sense to handle this in MIRBuilder because the other passes may insert instructions that are not in canonical form after the canonicalization.


Repository:
  rL LLVM

https://reviews.llvm.org/D51362





More information about the llvm-commits mailing list