[PATCH] D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 15:08:22 PDT 2018


aemerson added reviewers: bogner, aditya_nandakumar, volkan.
aemerson added a comment.

I'm not against a separate IR canonicalization stage, even though it's a bit overkill for this particular case. At the moment it looks like InstCombine is doing the canonicalizaton for this case, so re-running that is out of the question. A new pass looks to be on the cards. Anyone else have opinions on this?


Repository:
  rL LLVM

https://reviews.llvm.org/D51362





More information about the llvm-commits mailing list