[PATCH] D51254: [X86] Replace support for vXi32 SMUL_LOHI/UMUL_LOHI with MULHS/MULHU support instead.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a few minors - cheers!



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22899
+
+    int NumElts = VT.getVectorNumElements();
+
----------------
Worth pulling out Op0/Op1/NumElts/IsSigned out into common code? We're repeating it in iXi8 lowering as well


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22943
+      ShufMask[i] = (i / 2) * 2 + ((i % 2) * NumElts) + 1;
+    }
+
----------------
Remove braces


Repository:
  rL LLVM

https://reviews.llvm.org/D51254