[PATCH] D51080: litsupport/remote: Work without shared filesystem

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D51080#1209934, @Meinersbur wrote:

> Can you outline the intended workflow? My guess:
>
> 1. cmake builddir for cross-compilation
> 2. make/ninja
> 3. rsync pushes test-suite builddir to target
> 4. llvm-lit locale, but run every command on remote using
> 5. including fpmc/VALIDATE step in *.test (SPEC2017 also uses `llvm_add_host_executable`)


The `VERIFY:` steps in the scripts are run remotely as well. I hope that takes part of the spec2017 validation things[*]

> 7. collect metrics from `.o.time`/`.link.time` files from local builddir and execution times using `remote_read_result_file` function.

Yes, things falling out of the compilation (compiletime plugin, stats plugin) is read locally, things that get produced while running a benchmark (timeit, microbenchmark modules) use `context.read_result_file()` which is assigned to `remote_read_result_file()` when running remotely (or `default_read_result_file()` otherwise)

> Is this correct?

Yes.

[X] I don't have a copy of SPEC2017 at the moment, so unfortunately I cannot actually test any of this stuff for it. We probably need some `llvm_test_data()` calls added to get SPEC2017 working anyway...


Repository:
  rT test-suite

https://reviews.llvm.org/D51080