[PATCH] D51080: litsupport/remote: Work without shared filesystem

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Can you outline the intended workflow? My guess:

1. cmake builddir for cross-compilation
2. make/ninja
3. rsync pushes test-suite builddir to target
4. llvm-lit locale, but run every command on remote using
5. including fpmc/VALIDATE step in *.test (SPEC2017 also uses `llvm_add_host_executable`)
6. collect metrics from `.o.time`/`.link.time` files from local builddir and execution times using `remote_read_result_file` function.

Is this correct?



================
Comment at: litsupport/modules/timeit.py:82-84
+def getUserTime(timefile):
     """Extract the user time form a .time file produced by timeit"""
+    l = [l for l in timefile.splitlines() if l.startswith('user')]
----------------
Did you consider keeping `getUserTime` with filename argument and extract-out the parsing step into a new function which can be called instead if there is not filename? There seems to be a bit of boilerplate added for every time the content is just a file (for collecting compile times).


================
Comment at: tools/CMakeLists.txt:1-3
 # Note that we have to compile fpcmp and timeit for the host machine even when
 # cross compiling to a different target. We use custom rules doing a simple
 # "cc file.c".
----------------
With the change below, this comment does not seem to apply anymore.


Repository:
  rT test-suite

https://reviews.llvm.org/D51080