[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a comment.

I think we should 1) retain the directory structure in Support that we had in Demangle, and 2) keep StringView in LLVM (I'm fine with making the API consistent with string_view's or StringRef's though).

I want to do 2) because we're going to have to support a hand-rolled string_view in the demangler (until C++17) regardless, and it seems needlessly messy and error-prone to have ItaniumDemangle.cpp and cxa_demangle.cpp call into two different implementation of the same thing. Also, I'm worried about drive-by refactoring of LLVM APIs diverging the two demanglers.

I want to do 1) as well because I think it's cleaner to have the rule: "the `Support/Demangle` directory is mirrored in `libcxxabi/src/Demangle`" than the rule: "A handful of random files in `Support` related to demangling are mirrored in libcxxabi". It would be nice if the demangler could live as a first-class citizen of Support, but it doesn't, and I don't think we should lie about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D50875