[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D50875#1203447, @rsmith wrote:

> In https://reviews.llvm.org/D50875#1203443, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D50875#1203430, @rsmith wrote:
> >
> > > I did not remove the StringView.h from lib/Support/Demangle, because the `StringView` class has a different interface from both `llvm::StringRef` and `std::string_view`, and keeping that file around to provide the interface that the demangling code wants seems like the best path for now. (libc++abi presumably can't depend on `std::string_view`, so needs its own implementation anyway.)
> >
> >
> > FWIW, I'd prefer that we make whatever libc++abi needs match the API of StringRef so that we can just have two modes for a single file, and leave the mini-StringRef-like thing in libc++abi....
>
>
> I'm fine with that as a direction if the owners of the demangler are happy with it. I'd like to keep this particular patch focused on just the file moves, though. (Removing Compiler.h was cheap to do as part of the move because the interface was identical to that of the Support version.)


My issue is that until that happens, we kind of have to put this in a separate directory within Support.

But I don't think that makes sense long-term, so it would seem useful to fix the StringView issue thing first, and then do the move. If fixing the StringView thing is really hard, then I would honestly prefer to name it DemanglerStringView.h or something so we don't have to add a directory component that will stop making sense later on...


Repository:
  rL LLVM

https://reviews.llvm.org/D50875