[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 16:25:54 PDT 2018


On Thu, Aug 16, 2018 at 4:21 PM Richard Smith - zygoloid via Phabricator <
reviews at reviews.llvm.org> wrote:

> rsmith added a comment.
>


> Potentially, yes, and Erik and I have discussed some ways to do that in
> the longer term. But I think the demangler belongs in Support regardless of
> whether or not we factor out that part.
>
> i do too, as a matter of principle.  But if we're gonna put it in support
and end up with a huge mess of ifdefs, potential for misuse, and
restrictions that don't apply to the rest of support, then as a practical
matter I don't think we shouldn't do it yet.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180816/a72a51bc/attachment.html>


More information about the llvm-commits mailing list