[PATCH] D50524: [Hexagon] Replace fatal error with remark in HexagonISelLowering

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Converting the memory operation to an explicit trap seems overly complicated, as opposed to just fixing whatever isel pattern is assuming the immediate is divisible by 4.  But I don't know the Hexagon backend that well.

Could you use the optimization remark emission infrastructure for this, instead of defining your own DiagnosticInfo?  SelectionDAG::getORE() returns an optimization remark emitter.  Granted, that wouldn't do exactly the same thing, since optimization remarks are only emitted when requested.


Repository:
  rL LLVM

https://reviews.llvm.org/D50524