[PATCH] D50406: SafeStack: Delay thread stack clean-up

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 12:33:11 PDT 2018


cryptoad added a comment.

In https://reviews.llvm.org/D50406#1194173, @vlad.tsyrklevich wrote:

> malloc() would only be called during thread destruction, so it doesn't seem like there should be an issue unless malloc() causes a thread to destruct and even then this function shouldn't re-enter because of the order of when pthread_setspecific() is called. Perhaps I'm just failing to imagine a situation under which this could be an issue?


Ack. Tried out a few things, as far as I can tell it works as intended.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50406





More information about the llvm-commits mailing list