[PATCH] D50406: SafeStack: Delay thread stack clean-up

Vlad Tsyrklevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 12:09:51 PDT 2018


vlad.tsyrklevich added a comment.

In https://reviews.llvm.org/D50406#1194152, @cryptoad wrote:

> Random thought: isn't the introduction of malloc here (as opposed to an OS backed alternative like mmap) gonna mess compatibility with other Sanitizers that intercept it? (thinking of Scudo which is currently compatible with SafeStack but I haven't tested).


malloc() would only be called during thread destruction, so it doesn't seem like there should be an issue unless malloc() causes a thread to destruct and even then this function shouldn't re-enter because of the order of when pthread_setspecific() is called. Perhaps I'm just failing to imagine a situation under which this could be an issue?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50406





More information about the llvm-commits mailing list