[PATCH] D49611: [X86] Improved sched models for X86 SHLD/SHRD* instructions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 06:15:58 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86Schedule.td:148
 defm WriteShift : X86SchedWritePair;
-// Double shift instructions.
-defm WriteShiftDouble : X86SchedWritePair;
+def  WriteSHDrri  : SchedWrite;
+def  WriteSHDrrcl : SchedWrite;
----------------
avt77 wrote:
> RKSimon wrote:
> > Keep the // Double shift instructions. comment here
> But I removed 
> 
> defm WriteShiftDouble : X86SchedWritePair;
> 
> Why do we need the comments?
Aren't WriteSHD double shift instructions ?


https://reviews.llvm.org/D49611





More information about the llvm-commits mailing list