[PATCH] D49611: [X86] Improved sched models for X86 SHLD/SHRD* instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ScheduleAtom.td:153
 
-////////////////////////////////////////////////////////////////////////////////
-// Double shift instructions.
-////////////////////////////////////////////////////////////////////////////////
-
-defm : AtomWriteResPair<WriteShiftDouble, [AtomPort0], [AtomPort0]>;
+// SHLD/SHRD (32-bit versions).
+defm : X86WriteRes<WriteSHDrri, [AtomPort01], 2, [2], 1>;
----------------
avt77 wrote:
> RKSimon wrote:
> > No need for the 32-bit comment - we don't do this for any other override cases.
> Are you sure? For other CPUs we have WriteSHDrri, WriteSHDrrcl,etc. for all sizes but in Atom it covers 32-bit version only. All other sizes have special redefinitions. To make this clear I put here this comment. Are you sure I have to remove it?
Yes I'm sure.


https://reviews.llvm.org/D49611