[PATCH] D49965: [MS Demangler] Demangle symbols in function local scopes

[Zachary Turner via llvm-commits]

I had thought of a tryDemangleNumber function but it didn’t really fit the
style of code . (Ie I don’t really do that anywhere else so it felt a
little out of place). I can still do that if you think it’s better, I don’t
have a strong preference
On Sun, Jul 29, 2018 at 2:33 PM David Majnemer via Phabricator <
reviews at reviews.llvm.org> wrote:

> majnemer added inline comments.
>
>
> ================
> Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:424-441
> +  // \?[0-9]\?
> +  if (Candidate.size() == 1)
> +    return Candidate[0] >= '0' && Candidate[0] <= '9';
> +
> +  // If it's not 0-9, then it's an encoded number terminated with an @
> +  if (Candidate.back() != '@')
> +    return false;
> ----------------
> Do you think it makes sense to share this logic w/
> Demangler::demangleNumber? Maybe add a tryDemangleNumber which returned the
> remaining portion of the string, the number, and whether or not an error
> occurred?
>
>
> https://reviews.llvm.org/D49965
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180729/65feffb8/attachment.html>