[PATCH] D49965: [MS Demangler] Demangle symbols in function local scopes

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:424-441
+  // \?[0-9]\?
+  if (Candidate.size() == 1)
+    return Candidate[0] >= '0' && Candidate[0] <= '9';
+
+  // If it's not 0-9, then it's an encoded number terminated with an @
+  if (Candidate.back() != '@')
+    return false;
----------------
Do you think it makes sense to share this logic w/ Demangler::demangleNumber? Maybe add a tryDemangleNumber which returned the remaining portion of the string, the number, and whether or not an error occurred?


https://reviews.llvm.org/D49965