[PATCH] D49575: Merge demangler changes over to libcxxabi

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: libcxxabi/src/demangle/Compiler.h:23
+#ifndef NDEBUG
+#if __has_attribute(noinline) && __has_attribute(used)
+#define DUMP_METHOD __attribute__((noinline, used))
----------------
erik.pilkington wrote:
> This depends on `__cxxabi_config.h` to make sure that `__has_attribute` is defined on compilers that don't support it. Please add the include.
Is there any harm to just #ifndef #def here instead of pulling in that whole header?


https://reviews.llvm.org/D49575