[PATCH] D49575: Merge demangler changes over to libcxxabi

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 16:48:33 PDT 2018


erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

`$ diff llvm-project/libcxxabi/src/demangle/StringView.h llvm-project/llvm/lib/Demangle/StringView.h` gives a bunch of junk, I used to be able to just use a script that basically called `patch` to copy the bulk of the changes over. Did you call clang-format or something?

I think this is fine though, so after deformatting and adding that include feel free to commit!



================
Comment at: libcxxabi/src/demangle/Compiler.h:23
+#ifndef NDEBUG
+#if __has_attribute(noinline) && __has_attribute(used)
+#define DUMP_METHOD __attribute__((noinline, used))
----------------
This depends on `__cxxabi_config.h` to make sure that `__has_attribute` is defined on compilers that don't support it. Please add the include.


https://reviews.llvm.org/D49575





More information about the llvm-commits mailing list