[PATCH] D49461: [LV] Fix for PR38110, LV encountered llvm_unreachable()

[silviu.baranga@arm.com via Phabricator via llvm-commits]

sbaranga added a comment.

In https://reviews.llvm.org/D49461#1166719, @hsaito wrote:

> In https://reviews.llvm.org/D49461#1166158, @sbaranga wrote:
>
> > Seems reasonable to me.
> >
> > Ideally we should be handling the phi node case (which is why the unreachable was there), but crashing doesn't seem like the right thing to do.
>
>
> Personally, I see a value in differentiating explicitly known handling versus just being conservative ----- but I don't mind converting that into a comment instead if that's preferred.


Sure. I don't have any strong preference here.

LGTM


Repository:
  rL LLVM

https://reviews.llvm.org/D49461