[PATCH] D49461: [LV] Fix for PR38110, LV encountered llvm_unreachable()

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 09:38:22 PDT 2018


hsaito added a comment.

In https://reviews.llvm.org/D49461#1166158, @sbaranga wrote:

> Seems reasonable to me.
>
> Ideally we should be handling the phi node case (which is why the unreachable was there), but crashing doesn't seem like the right thing to do.


Personally, I see a value in differentiating explicitly known handling versus just being conservative ----- but I don't mind converting that into a comment instead if that's preferred.


Repository:
  rL LLVM

https://reviews.llvm.org/D49461





More information about the llvm-commits mailing list