[PATCH] D49493: [DebugInfo] Reduce debug_str_offsets section size

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A few typos.

I would like a test that did the following:  add string "A" not indexed; add string "B" indexed; add string "A" indexed.
Then show that the string section has "A" followed by "B", and the offsets table is correct (entry 0 points to "B", entry 1 points to "A").
Is that feasible?



================
Comment at: lib/CodeGen/AsmPrinter/DwarfStringPool.cpp:59
+
+  std::sort(
+      Entries.begin(), Entries.end(),
----------------
`llvm::sort`


================
Comment at: lib/CodeGen/AsmPrinter/DwarfStringPool.h:52
+  /// intend to refer to this string using the indexed forms (DW_FORM_strx,
+  /// ...). In this case, the string will be assigned an index ID, and it's
+  /// offset will be emitted in the respective offsets section.
----------------
s/it's/its/


================
Comment at: test/DebugInfo/X86/string-offsets-table.ll:97
+; verify that the extracted string offsets are referenced correctly. The
+; sections should contain only the offsets that of strings that are actually
+; referenced by the debug info.
----------------
... offsets of strings ...


Repository:
  rL LLVM

https://reviews.llvm.org/D49493