[PATCH] D49493: [DebugInfo] Reduce debug_str_offsets section size

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 10:37:17 PDT 2018


mgrang added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfStringPool.cpp:59
+
+  std::sort(
+      Entries.begin(), Entries.end(),
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


Repository:
  rL LLVM

https://reviews.llvm.org/D49493





More information about the llvm-commits mailing list