[PATCH] D49248: [TargetLowering] Add support for non-uniform vectors to BuildUDIV

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17829
+  SDValue N1 = N->getOperand(1);
+  if (!isConstantOrConstantVector(N1) || !DAG.isKnownNeverZero(N1))
     return SDValue();
----------------
lebedev.ri wrote:
> `isKnownNeverZero()` should also probably be wary of `undef`?
If its a constant build vector then isKnownNeverZero() will return false if any elements contain undef.


Repository:
  rL LLVM

https://reviews.llvm.org/D49248