[PATCH] D49248: [TargetLowering] Add support for non-uniform vectors to BuildUDIV

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 14 06:30:57 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17829
+  SDValue N1 = N->getOperand(1);
+  if (!isConstantOrConstantVector(N1) || !DAG.isKnownNeverZero(N1))
     return SDValue();
----------------
`isKnownNeverZero()` should also probably be wary of `undef`?


Repository:
  rL LLVM

https://reviews.llvm.org/D49248





More information about the llvm-commits mailing list