[PATCH] D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- Thanks, @Maknee!

One style comment, and I'm happy to land after that.

You might also want to consider applying for commit access if you would like to continue working on parts of XRay moving forward.

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access



================
Comment at: llvm/lib/XRay/Trace.cpp:128-135
+          (FileHeader.Version >= 3 ? Record.PId != PId : false)) {
         return make_error<StringError>(
             Twine("Corrupted log, found arg payload following non-matching "
                   "function + thread record. Record for function ") +
                 Twine(Record.FuncId) + " != " + Twine(FuncId) + "; offset: " +
                 Twine(S.data() - Data.data()),
             std::make_error_code(std::errc::executable_format_error));
----------------
Minor/Style: We don't generally add curly braces for if statements that only have one statement in the branches.


https://reviews.llvm.org/D49153