[PATCH] D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode

[Henry Zhu via Phabricator via llvm-commits]

Maknee updated this revision to Diff 155261.
Maknee marked an inline comment as done.
Maknee added a comment.

Changes llvm-xray:

- convert mode checks for differences in header version numbers when parsing/outputting values (to make sure older traces won't generate errors)

Updates to test cases:

- Added 4 xray outputs into Inputs directory for version 3 (basic with/without arg1, fdr with/without arg1)
- Added 4 different test cases for version 3 that checks the output of convert mode

Made sure test cases with the older header versions and the newer header version passed.


https://reviews.llvm.org/D49153

Files:
  compiler-rt/lib/xray/tests/unit/fdr_logging_test.cc
  compiler-rt/lib/xray/xray_basic_logging.cc
  compiler-rt/lib/xray/xray_fdr_log_records.h
  compiler-rt/lib/xray/xray_fdr_logging.cc
  compiler-rt/test/xray/TestCases/Posix/fdr-mode.cc
  compiler-rt/test/xray/TestCases/Posix/fdr-single-thread.cc
  compiler-rt/test/xray/TestCases/Posix/fdr-thread-order.cc
  compiler-rt/test/xray/TestCases/Posix/fork_basic_logging.cc
  llvm/include/llvm/XRay/XRayRecord.h
  llvm/include/llvm/XRay/YAMLXRayRecord.h
  llvm/lib/XRay/Trace.cpp
  llvm/test/tools/llvm-xray/X86/Inputs/basic-log-arg1-version-3.xray
  llvm/test/tools/llvm-xray/X86/Inputs/basic-log-version-3.xray
  llvm/test/tools/llvm-xray/X86/Inputs/fdr-log-arg1-version-3.xray
  llvm/test/tools/llvm-xray/X86/Inputs/fdr-log-version-3.xray
  llvm/test/tools/llvm-xray/X86/convert-basic-log-arg1-version3-to-yaml.txt
  llvm/test/tools/llvm-xray/X86/convert-basic-log-version3-to-yaml.txt
  llvm/test/tools/llvm-xray/X86/convert-fdr-log-arg1-version3-to-yaml.txt
  llvm/test/tools/llvm-xray/X86/convert-fdr-log-version3-to-yaml.txt
  llvm/tools/llvm-xray/xray-account.cpp
  llvm/tools/llvm-xray/xray-converter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49153.155261.patch
Type: text/x-patch
Size: 38636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180712/7dbae7b4/attachment.bin>