[PATCH] D49214: [DWARF v5] emit DWARF v5 range lists (no support for fission yet)

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 10:41:47 PDT 2018


wolfgangp added a comment.

Thanks for the quick review.



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:651
+  if (getDwarfVersion() >= 5)
+    (useSplitDwarf() ? SkeletonHolder : InfoHolder)
+        .setRnglistsTableBaseSym(Asm->createTempSymbol("rnglists_table_base"));
----------------
aprantl wrote:
> perhaps add a `getSkeletonOrInfoHolder()` accessor?
That would require a few more changes in unrelated places (this stanza is used a few times elsewhere). I'll do that in a separate commit.


https://reviews.llvm.org/D49214





More information about the llvm-commits mailing list