[PATCH] D49214: [DWARF v5] emit DWARF v5 range lists (no support for fission yet)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks, I think this looks good!



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:651
+  if (getDwarfVersion() >= 5)
+    (useSplitDwarf() ? SkeletonHolder : InfoHolder)
+        .setRnglistsTableBaseSym(Asm->createTempSymbol("rnglists_table_base"));
----------------
perhaps add a `getSkeletonOrInfoHolder()` accessor?


================
Comment at: lib/MC/MCObjectFileInfo.cpp:271
+  DwarfRnglistsSection =
+      Ctx->getMachOSection("__DWARF", "__debug_rnglists", MachO::S_ATTR_DEBUG,
+                           SectionKind::getMetadata(), "debug_range");
----------------
Looks like that fits exactly into the 16 available characters :-)


https://reviews.llvm.org/D49214