[PATCH] D48541: [Bitcode, Type] Assign deterministic IDs to unnamed types at creation time.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Bitcode/Writer/ValueEnumerator.cpp:330
+  for (auto &T : Type::getUnnamedTypes(M.getContext()))
+    EnumerateType(T.first);
+
----------------
efriedma wrote:
> Changing the order we emit the types should be fine. I'm a little concerned this will make us emit unused types in bitcode.
Ah yes, thanks! I'll update the patch, I am just looking for the best way to order the unnamed types as needed while also preserving the required order for type references, which seems slightly tricky.


https://reviews.llvm.org/D48541