[PATCH] D48541: [Bitcode, Type] Assign deterministic IDs to unnamed types at creation time.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 12:42:49 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Bitcode/Writer/ValueEnumerator.cpp:330
+  for (auto &T : Type::getUnnamedTypes(M.getContext()))
+    EnumerateType(T.first);
+
----------------
Changing the order we emit the types should be fine. I'm a little concerned this will make us emit unused types in bitcode.


https://reviews.llvm.org/D48541





More information about the llvm-commits mailing list