[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D48584#1148383, @spatel wrote:

> In https://reviews.llvm.org/D48584#1146822, @spatel wrote:
>
> > In https://reviews.llvm.org/D48584#1144405, @mkazantsev wrote:
> >
> > > I think that these changes are practically either unimportant or positive. SCEV has reasons to prefer `lt/gt` comparisons over `ne/eq` because in certain cases it can derive more facts from it, however I'm not sure whether it has real profit anywhere or not. I can test it on our Java benchmarks, but don't have environment to run C++ clang tests properly, so I'd appreciate if you could help with it.
> >
> >
> > Ok - I need to get a test-suite machine set up again. I'll try to have some data by tomorrow.
>
>
> I don't see anything above the noise with this patch applied, so we should be ok here.


LGTM then.


https://reviews.llvm.org/D48584