[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 05:39:02 PDT 2018


spatel added inline comments.


================
Comment at: test/Transforms/InstCombine/icmp_sdiv_with_and_without_range.ll:5
 ; Test that presence of range does not cause unprofitable transforms with bit
 ; arithmetics, and instcombine behaves exactly the same as without the range.
 
----------------
This comment isn't correct - as the test shows. Instcombine should do better with the range metadata, and I think that's true now (at least in this case).


https://reviews.llvm.org/D48584





More information about the llvm-commits mailing list