[lld] r335992 - [ELF] Set -o because current directory may not be writable during a test

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 01:33:03 PDT 2018


On Sat, Jun 30, 2018 at 2:12 AM Fangrui Song via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: maskray
> Date: Fri Jun 29 10:07:22 2018
> New Revision: 335992
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335992&view=rev
> Log:
> [ELF] Set -o because current directory may not be writable during a test
>
> Modified:
>     lld/trunk/test/ELF/map-file-i686.s
>
> Modified: lld/trunk/test/ELF/map-file-i686.s
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/map-file-i686.s?rev=335992&r1=335991&r2=335992&view=diff
>
> ==============================================================================
> --- lld/trunk/test/ELF/map-file-i686.s (original)
> +++ lld/trunk/test/ELF/map-file-i686.s Fri Jun 29 10:07:22 2018
> @@ -1,7 +1,7 @@
>  // REQUIRES: x86
>
>  // RUN: llvm-mc -filetype=obj -triple=i386-pc-linux %s -o %t1.o
> -// RUN: ld.lld %t1.o -M | FileCheck -strict-whitespace %s
> +// RUN: ld.lld %t1.o -o %t1 -M | FileCheck -strict-whitespace %s
>

Super nit, so you don't need to make another commit for this comment, but
`-o /dev/null` is perhaps slightly better if you don't need an output file.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180702/c7031d84/attachment.html>


More information about the llvm-commits mailing list