<div dir="ltr">On Sat, Jun 30, 2018 at 2:12 AM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: maskray<br>
Date: Fri Jun 29 10:07:22 2018<br>
New Revision: 335992<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=335992&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=335992&view=rev</a><br>
Log:<br>
[ELF] Set -o because current directory may not be writable during a test<br>
<br>
Modified:<br>
    lld/trunk/test/ELF/map-file-i686.s<br>
<br>
Modified: lld/trunk/test/ELF/map-file-i686.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/map-file-i686.s?rev=335992&r1=335991&r2=335992&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/map-file-i686.s?rev=335992&r1=335991&r2=335992&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/map-file-i686.s (original)<br>
+++ lld/trunk/test/ELF/map-file-i686.s Fri Jun 29 10:07:22 2018<br>
@@ -1,7 +1,7 @@<br>
 // REQUIRES: x86<br>
<br>
 // RUN: llvm-mc -filetype=obj -triple=i386-pc-linux %s -o %t1.o<br>
-// RUN: ld.lld %t1.o -M | FileCheck -strict-whitespace %s<br>
+// RUN: ld.lld %t1.o -o %t1 -M | FileCheck -strict-whitespace %s<br></blockquote><div><br></div><div>Super nit, so you don't need to make another commit for this comment, but `-o /dev/null` is perhaps slightly better if you don't need an output file.</div></div></div>