[llvm] r335314 - Fix test failures after r335306 due to the pipeline changing.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 17:32:26 PDT 2018


Author: chandlerc
Date: Thu Jun 21 17:32:26 2018
New Revision: 335314

URL: http://llvm.org/viewvc/llvm-project?rev=335314&view=rev
Log:
Fix test failures after r335306 due to the pipeline changing.

This wasn't obvious for the author to fix because this is the first
pipeline use of the magic utility to get function analyses within
a module pass in the lagecy pass manager. Turns out that has a bug which
prevents dumping the structure of the pipeline and shows up as an
unnamed pass.

I've just left a FIXME for that as it doesn't seem likely worth fixing
and certainly shouldn't hold up getting the bots green.

Modified:
    llvm/trunk/test/Other/opt-O2-pipeline.ll
    llvm/trunk/test/Other/opt-O3-pipeline.ll
    llvm/trunk/test/Other/opt-Os-pipeline.ll

Modified: llvm/trunk/test/Other/opt-O2-pipeline.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-O2-pipeline.ll?rev=335314&r1=335313&r2=335314&view=diff
==============================================================================
--- llvm/trunk/test/Other/opt-O2-pipeline.ll (original)
+++ llvm/trunk/test/Other/opt-O2-pipeline.ll Thu Jun 21 17:32:26 2018
@@ -249,6 +249,10 @@
 ; CHECK-NEXT:     Strip Unused Function Prototypes
 ; CHECK-NEXT:     Dead Global Elimination
 ; CHECK-NEXT:     Merge Duplicate Global Constants
+; CHECK-NEXT:     CGProfilePass
+; FIXME: This pass uses the magic "on-demand function analysis" feature of the
+; legacy pass manager and doesn't correctly print pass names.
+; CHECK-NEXT:       Unnamed pass
 ; CHECK-NEXT:     FunctionPass Manager
 ; CHECK-NEXT:       Dominator Tree Construction
 ; CHECK-NEXT:       Natural Loop Information

Modified: llvm/trunk/test/Other/opt-O3-pipeline.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-O3-pipeline.ll?rev=335314&r1=335313&r2=335314&view=diff
==============================================================================
--- llvm/trunk/test/Other/opt-O3-pipeline.ll (original)
+++ llvm/trunk/test/Other/opt-O3-pipeline.ll Thu Jun 21 17:32:26 2018
@@ -253,6 +253,10 @@
 ; CHECK-NEXT:     Strip Unused Function Prototypes
 ; CHECK-NEXT:     Dead Global Elimination
 ; CHECK-NEXT:     Merge Duplicate Global Constants
+; CHECK-NEXT:     CGProfilePass
+; FIXME: This pass uses the magic "on-demand function analysis" feature of the
+; legacy pass manager and doesn't correctly print pass names.
+; CHECK-NEXT:       Unnamed pass
 ; CHECK-NEXT:     FunctionPass Manager
 ; CHECK-NEXT:       Dominator Tree Construction
 ; CHECK-NEXT:       Natural Loop Information

Modified: llvm/trunk/test/Other/opt-Os-pipeline.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-Os-pipeline.ll?rev=335314&r1=335313&r2=335314&view=diff
==============================================================================
--- llvm/trunk/test/Other/opt-Os-pipeline.ll (original)
+++ llvm/trunk/test/Other/opt-Os-pipeline.ll Thu Jun 21 17:32:26 2018
@@ -235,6 +235,10 @@
 ; CHECK-NEXT:     Strip Unused Function Prototypes
 ; CHECK-NEXT:     Dead Global Elimination
 ; CHECK-NEXT:     Merge Duplicate Global Constants
+; CHECK-NEXT:     CGProfilePass
+; FIXME: This pass uses the magic "on-demand function analysis" feature of the
+; legacy pass manager and doesn't correctly print pass names.
+; CHECK-NEXT:       Unnamed pass
 ; CHECK-NEXT:     FunctionPass Manager
 ; CHECK-NEXT:       Dominator Tree Construction
 ; CHECK-NEXT:       Natural Loop Information




More information about the llvm-commits mailing list