[PATCH] D42805: [utils] Refactor utils/update_{, llc_}test_checks.py to share more code

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 01:03:24 PDT 2018


lebedev.ri added inline comments.


================
Comment at: llvm/trunk/utils/UpdateTestChecks/common.py:64
+  # whitespace in place.
+  body = SCRUB_WHITESPACE_RE.sub(r' ', body)
+  # Expand the tabs used for indentation.
----------------
Hi @MaskRay.

I think there is something wrong with this particular line.

If the whitespace isn't leading/trailing, removing it will change the line,
and FileCheck will no longer match this line. So, how can we even do this?

This particular line breaks `utils/update_analyze_test_checks.py`
Try on `test/Analysis/ScalarEvolution/*mask.ll`


Repository:
  rL LLVM

https://reviews.llvm.org/D42805





More information about the llvm-commits mailing list