[PATCH] D42805: [utils] Refactor utils/update_{, llc_}test_checks.py to share more code

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/trunk/utils/UpdateTestChecks/common.py:64
+  # whitespace in place.
+  body = SCRUB_WHITESPACE_RE.sub(r' ', body)
+  # Expand the tabs used for indentation.
----------------
lebedev.ri wrote:
> Hi @MaskRay.
> 
> I think there is something wrong with this particular line.
> 
> If the whitespace isn't leading/trailing, removing it will change the line,
> and FileCheck will no longer match this line. So, how can we even do this?
> 
> This particular line breaks `utils/update_analyze_test_checks.py`
> Try on `test/Analysis/ScalarEvolution/*mask.ll`
Sorry but I don't have any idea what has been going on... When I spli clean up the script... utils/update_analyze_test_checks.py did not exist then..


Repository:
  rL LLVM

https://reviews.llvm.org/D42805